Repository navigation
2101 record dashboard - #671
Conversation
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR reviewed - minor comments added.
| "globe_options", | ||
| "tl_options", # Deprecated | ||
| { data_type => "text", is_nullable => 1 }, | ||
| "globe_options", # Deprecated |
There was a problem hiding this comment.
Assuming the removal of these two widgets would fall under a separate PR further down the roadmap?
There was a problem hiding this comment.
Yes, that's correct. With DBIx::Class::Migration, it's not very easy to both move content and delete fields at the same time.
| !$timeline_range || $timeline_range =~ /^(3|6|12|24)$/ | ||
| or error __x"Invalid timeline range: {range}", range => $timeline_range; | ||
| error "Unexpected keys in widget configuration" | ||
| if keys %options; |
There was a problem hiding this comment.
This may be just a personal preference, however, could this codeblock be formatted slightly better? Currently it's not too easy to navigate.
There was a problem hiding this comment.
Quite possibly, suggestions welcome :)
| page => 1, | ||
| view => $view, | ||
| rows => $self->rows, | ||
| #rewind => session('rewind'), # Maybe add in the future |
There was a problem hiding this comment.
May be appropriate to update the relevant ticket, if not already, with this comment so it doesn't fall unnoticed.
There was a problem hiding this comment.
Thanks, good point, created as 2235.
| # latter, GADS::Records currently does not support retrieval as | ||
| # such, so convert these into the parent only. Thus these dates | ||
| # will only be rendered if the field in question is included as a | ||
| # displayed field in the curcommon field. |
48c8b71 to
d17874d
Compare
d17874d to
644f94f
Compare
…oards as expected
Remove extra select-reveal defined by mistake Use already defined select-reveal in place of the above
- Set up workflow tests to run sequentially - Minimise cypress config - Update cypress test to properly find new modal component
644f94f to
66f87e5
Compare
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
PR re-reviewed, looks fine to me so far.
Removed commented out SelectRevealComponent registration
No description provided.