Repository navigation
better self-reference handling and status change improvements - #4
Merged
Merged
Conversation
--basepath is not needed for valid documents We can always derive it from the original self-reference if the input document was not valid, the output can't be valid anyway
tracking id: don't fallback to uuid4, always use the generated name based on current date/time replace obsolete datetime.datetime.utcnow
The CSAF specification requires the status `draft` for version specifications with with major version `0` and pre-release versions (CSAF 2.0 specification sections 3.1.11.1 and 3.1.11.2). With the automatic increament of the major version, a document may loose the requirement for the `draft` state. Then the status is set to `final`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the unneeded
--basepath, making the self-reference logic fully automaticAlways generate meaningful Tracking IDs (no UUID4)
Replace the obsolete function
datetime.datetime.utcnowHandle status change depending on version
Clarify this is CSAF 2.0 spec