Repository navigation
pin maven wrapper to version 3.9.16 - #362
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The pin, checksum, and Dependabot dependency rule are consistent with the documented publishing incompatibility.
0 open findings
What changed in this PR
Pins Maven to 3.9.16 to keep Maven Central publishing compatible.
Changes:
- Downgrades Maven Wrapper from 3.10.0 to 3.9.16 with the matching checksum.
- Prevents Dependabot from upgrading Maven to 3.10.0 or later.
| File | Description |
|---|---|
.mvn/wrapper/maven-wrapper.properties |
Pins Maven 3.9.16. |
.github/dependabot.yml |
Blocks incompatible Maven upgrades. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe Maven wrapper distribution changes from version 3.10.0 to 3.9.16, and its checksum is updated. Dependabot is configured to ignore Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The release workflow uses Maven 3.9.16, avoiding the described Maven 3.10 publishing issue. The checksum and update exclusion are consistent, and no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ignore updates for Apache Maven version 3.10.0 and above due to compatibility issues. See also cryptomator/cryptofs#362
Maven 3.10.0 changes what ends up in the bundle that central-publishing-maven-plugin 0.11.0 uploads, and Maven Central rejects the result.
central-publishing-plugin"installs" artifacts into a staging directory laid out like a Maven repository, then zips that directory into central-bundle.zip. With maven 3.10.0 that staging directory also gets the bookkeeping files a normal local repository (~/.m2) keeps (i.e maven-metadata-local.xml). Central repo requires every directory with content to contain a .pom, and org/cryptomator/cryptofs/ has only the metadata file, leading to rejection.There's no config workaround yet. 0.11.0 is the newest plugin version and doesn't filter these files out. No Maven property brings back the old layout, since -llr is gone. So pinning the wrapper to 3.9.16 and blocking dependabot from bumping past it is the fix for now. The issue suggests revisiting this once the plugin handles 3.10.
Sources: