Skip to content

pin maven wrapper to version 3.9.16 - #362

Merged
infeo merged 1 commit into
developfrom
fix/pin-maven-3.9.16
Oct 8, 2026
Merged

infeo merged 1 commit into
developfrom
fix/pin-maven-3.9.16

Conversation

@infeo

@infeo infeo commented Oct 8, 2026

Copy link
Copy Markdown
Member

Maven 3.10.0 changes what ends up in the bundle that central-publishing-maven-plugin 0.11.0 uploads, and Maven Central rejects the result.

central-publishing-plugin "installs" artifacts into a staging directory laid out like a Maven repository, then zips that directory into central-bundle.zip. With maven 3.10.0 that staging directory also gets the bookkeeping files a normal local repository (~/.m2) keeps (i.e maven-metadata-local.xml). Central repo requires every directory with content to contain a .pom, and org/cryptomator/cryptofs/ has only the metadata file, leading to rejection.

There's no config workaround yet. 0.11.0 is the newest plugin version and doesn't filter these files out. No Maven property brings back the old layout, since -llr is gone. So pinning the wrapper to 3.9.16 and blocking dependabot from bumping past it is the fix for now. The issue suggests revisiting this once the plugin handles 3.10.

Sources:

Copilot AI balanced review requested due to automatic review settings October 8, 2026 00:16
@infeo infeo self-assigned this Oct 8, 2026
@infeo infeo added this to the next milestone Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The pin, checksum, and Dependabot dependency rule are consistent with the documented publishing incompatibility.

0 open findings

What changed in this PR

Pins Maven to 3.9.16 to keep Maven Central publishing compatible.

Changes:

  • Downgrades Maven Wrapper from 3.10.0 to 3.9.16 with the matching checksum.
  • Prevents Dependabot from upgrading Maven to 3.10.0 or later.
File Description
.mvn/​wrapper/​maven-wrapper.properties Pins Maven 3.9.16.
.github/​dependabot.yml Blocks incompatible Maven upgrades.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2b2ebefe-705a-4024-b50f-8e3783a6f404
📥 Commits

Reviewing files that changed from the base of the PR and between 2e63636 and 829db23.

📒 Files selected for processing (2)
  • .github/dependabot.yml
  • .mvn/wrapper/maven-wrapper.properties

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The Maven wrapper distribution changes from version 3.10.0 to 3.9.16, and its checksum is updated. Dependabot is configured to ignore org.apache.maven:apache-maven versions 3.10.0 and later.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 829db

The release workflow uses Maven 3.9.16, avoiding the described Maven 3.10 publishing issue. The checksum and update exclusion are consistent, and no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: pinning the Maven wrapper to version 3.9.16.
Description check ✅ Passed The description explains the Maven 3.10.0 incompatibility with central-publishing-maven-plugin, the Maven Central rejection, and the reason for pinning Maven to 3.9.16 and blocking Dependabot upgrades…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@infeo
infeo merged commit 8249c44 into develop Oct 8, 2026
14 of 15 checks passed
@infeo
infeo deleted the fix/pin-maven-3.9.16 branch October 8, 2026 08:38
infeo added a commit to cryptomator/cryptolib that referenced this pull request Oct 12, 2026
Ignore updates for Apache Maven version 3.10.0 and above due to compatibility issues.

See also cryptomator/cryptofs#362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants