Skip to content

Update dependencies - #660

Merged
SailReal merged 1 commit into
developfrom
feature/update-dependencies
Sep 17, 2026
Merged

SailReal merged 1 commit into
developfrom
feature/update-dependencies

Conversation

@SailReal

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fa50c070-407b-495a-85f2-d6e58d04d15e

📥 Commits

Reviewing files that changed from the base of the PR and between 6885b13 and 07b8a92.

⛔ Files ignored due to path filters (1)
  • gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
📒 Files selected for processing (24)
  • .github/workflows/build.yml
  • README.md
  • build.gradle
  • buildsystem/Dockerfile
  • buildsystem/dependencies.gradle
  • buildsystem/docker/dependencies.txt
  • data/build.gradle
  • domain/build.gradle
  • generator-api/build.gradle
  • generator/build.gradle
  • generator/src/main/java/org/cryptomator/generator/ActivityProcessor.java
  • generator/src/main/java/org/cryptomator/generator/CallbackProcessor.java
  • generator/src/main/java/org/cryptomator/generator/FragmentProcessor.java
  • generator/src/main/java/org/cryptomator/generator/InstanceStateProcessor.java
  • generator/src/main/java/org/cryptomator/generator/IntentProcessor.java
  • generator/src/main/java/org/cryptomator/generator/UseCaseProcessor.java
  • gradle.properties
  • gradle/wrapper/gradle-wrapper.properties
  • gradlew
  • gradlew.bat
  • presentation/build.gradle
  • presentation/src/main/java/org/cryptomator/presentation/CryptomatorApp.kt
  • settings.gradle
  • util/build.gradle

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


Walkthrough

The project now uses Java 21 across CI, Docker, Gradle modules, and annotation processors. Android compile and target SDK versions increase to 37. AGP updates to 9.4.0, and Gradle updates to 9.6.0. JUnit Platform Launcher dependencies are added. Multidex configuration and dependencies are removed. The Gradle wrapper scripts and project naming configuration are updated.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 07b8a

The modernization changes are internally consistent across the reviewed build and application configuration, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 7 files. (17 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the description does not explain any part of the changeset. Add a concise description that summarizes the Java 21, Gradle, Android SDK, dependency, and multidex updates.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title refers to real dependency updates, including Java, Gradle, Android SDK, and library changes. It is broad and does not identify the main upgrade scope, but it remains related to the changeset…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 7 files. (17 skipped: 17 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/update-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SailReal
SailReal merged commit c79f0f9 into develop Sep 17, 2026
3 checks passed
@SailReal
SailReal deleted the feature/update-dependencies branch September 17, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant