Migrate Greendao to Room

[SailReal]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bb810c15-0d7c-4ef6-a730-0fa3c2ffefe8

📥 Commits

Reviewing files that changed from the base of the PR and between b74a750 and fb5a44e.

📒 Files selected for processing (45)

• build.gradle
• buildsystem/dependencies.gradle
• data/build.gradle
• data/schemas/org.cryptomator.data.db.CryptomatorDatabase/14.json
• data/src/androidTest/java/org/cryptomator/data/db/CryptomatorDatabaseMigrationTest.kt
• data/src/androidTest/java/org/cryptomator/data/db/CryptomatorDatabaseTest.kt
• data/src/androidTest/java/org/cryptomator/data/db/LegacyDatabaseV1.kt
• data/src/androidTest/java/org/cryptomator/data/db/UpgradeDatabaseTest.kt
• data/src/main/java/org/cryptomator/data/db/CompoundDatabaseUpgrade.java
• data/src/main/java/org/cryptomator/data/db/CryptomatorDatabase.java
• data/src/main/java/org/cryptomator/data/db/Database.java
• data/src/main/java/org/cryptomator/data/db/DatabaseFactory.java
• data/src/main/java/org/cryptomator/data/db/DatabaseModule.java
• data/src/main/java/org/cryptomator/data/db/DatabaseUpgrade.java
• data/src/main/java/org/cryptomator/data/db/DatabaseUpgrades.java
• data/src/main/java/org/cryptomator/data/db/InitialDataCallback.java
• data/src/main/java/org/cryptomator/data/db/Sql.java
• data/src/main/java/org/cryptomator/data/db/Upgrade0To1.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade10To11.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade11To12.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade12To13.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade13To14.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade1To2.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade2To3.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade3To4.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade4To5.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade5To6.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade6To7.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade7To8.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade8To9.kt
• data/src/main/java/org/cryptomator/data/db/Upgrade9To10.kt
• data/src/main/java/org/cryptomator/data/db/dao/CloudDao.java
• data/src/main/java/org/cryptomator/data/db/dao/UpdateCheckDao.java
• data/src/main/java/org/cryptomator/data/db/dao/VaultDao.java
• data/src/main/java/org/cryptomator/data/db/entities/CloudEntity.java
• data/src/main/java/org/cryptomator/data/db/entities/DatabaseEntity.java
• data/src/main/java/org/cryptomator/data/db/entities/UpdateCheckEntity.java
• data/src/main/java/org/cryptomator/data/db/entities/VaultEntity.java
• data/src/main/java/org/cryptomator/data/db/entities/VaultWithCloud.java
• data/src/main/java/org/cryptomator/data/db/mappers/EntityMapper.java
• data/src/main/java/org/cryptomator/data/db/mappers/VaultEntityMapper.java
• data/src/main/java/org/cryptomator/data/repository/CloudRepositoryImpl.java
• data/src/main/java/org/cryptomator/data/repository/UpdateCheckRepositoryImpl.java
• data/src/main/java/org/cryptomator/data/repository/VaultRepositoryImpl.java
• presentation/src/main/java/org/cryptomator/presentation/di/component/ApplicationComponent.java

💤 Files with no reviewable changes (6)

• data/src/main/java/org/cryptomator/data/db/Database.java
• build.gradle
• data/src/main/java/org/cryptomator/data/db/DatabaseFactory.java
• data/src/main/java/org/cryptomator/data/db/entities/DatabaseEntity.java
• data/src/main/java/org/cryptomator/data/db/Upgrade0To1.kt
• data/src/main/java/org/cryptomator/data/db/CompoundDatabaseUpgrade.java

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

The database layer changes from GreenDAO to AndroidX Room. Build configuration, entities, DAOs, schema export, migrations, and dependency injection are updated. Repositories now use type-specific DAOs. Legacy migration tests use SupportSQLiteDatabase and validate migration paths, persistence behavior, relation handling, constraints, and initial data.

Priority: ⬇️ Low

Estimated code review effort: 5 (Critical) | ~90 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to fb5a4

No concrete merge-blocking risk remains from the reviewed changes.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 219 functions across 36 files. (3 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided, so its relevance to the changeset cannot be assessed.	Add a brief description of the GreenDAO-to-Room migration, including the database, DAO, entity, and migration changes.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: migrating from GreenDAO to Room.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 219 functions across 36 files. (3 skipped: 3 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/hello-room

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}