Fix move cloud nodes folders up

[SailReal]

This fixes #651 and was introduces with targetSdk 36 and the predictive back handling

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f11f0d2b-4c5d-4cff-bd5d-b8180879b82a

📥 Commits

Reviewing files that changed from the base of the PR and between d441dc0 and f78d43f.

📒 Files selected for processing (4)

• presentation/src/main/java/org/cryptomator/presentation/ui/activity/BaseActivity.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/activity/BrowseFilesActivity.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/activity/TextEditorActivity.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/activity/WelcomeActivity.kt

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

Back-press handling moved from deprecated activity overrides to AndroidX OnBackPressedCallback instances in three activities. BaseActivity now provides a helper that temporarily disables the current callback before dispatching the default back action. BrowseFilesActivity preserves selection, stack, and move-operation behavior. TextEditorActivity preserves editor navigation behavior. WelcomeActivity routes back presses to goBackOrExit().

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to f78d4

The back-navigation migration preserves move-folder parent navigation and default activity navigation. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The BaseActivity helper supports the new BrowseFilesActivity back handling. The TextEditorActivity and WelcomeActivity migrations change back behavior in screens that do not participate in clo…	Remove the unrelated TextEditorActivity and WelcomeActivity back-handling changes, or link a coding requirement that includes a global predictive-back migration.
Docstring Coverage	⚠️ Warning	Docstring coverage is 3.85% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 26 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title describes the main change: fixing navigation to parent folders while moving cloud nodes. The wording is concise but grammatically awkward.
Description check	✅ Passed	The description identifies the issue, the target SDK and predictive back handling, and the related fix. It is directly related to the changeset.
Linked Issues check	✅ Passed	For [#651], BrowseFilesActivity registers an OnBackPressedCallback. In MOVE_CLOUD_NODE, the callback creates a back stack entry for the parent folder when no fragment back stack entry exists. It…

Full details: Out of Scope Changes check

Explanation

The BaseActivity helper supports the new BrowseFilesActivity back handling. The TextEditorActivity and WelcomeActivity migrations change back behavior in screens that do not participate in cloud-folder moves and do not implement [#651]. These changes extend the pull request beyond the linked issue's folder-navigation scope.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/fix-move-cloud-nodes-up

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}