Skip to content

style: fix prettier formatting for CredentialFormatType union - #455

Merged
ankita-p17 merged 1 commit into
mainfrom
chore/fix-prettier-type-formatting
Oct 20, 2026
Merged

ankita-p17 merged 1 commit into
mainfrom
chore/fix-prettier-type-formatting

Conversation

@ajile-in

@ajile-in ajile-in commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Problem

The Validate CI job has been failing on main since #451 was merged (6b19172):

src/controllers/types.ts
  144:3  error  Replace `| LegacyIndyCredentialFormat⏎  | DidCommJsonLdCredentialFormat⏎ ` with `LegacyIndyCredentialFormat | DidCommJsonLdCredentialFormat`  prettier/prettier

This is the only eslint error in the repository (158 problems (1 error, 158 warnings)), so it fails yarn lint for every PR — including #454, which is otherwise unrelated to this file.

Change

Collapse the CredentialFormatType union onto a single line to satisfy prettier/prettier with the repo's printWidth: 120, semi: false, singleQuote: true config.

Verification

  • yarn lint → 158 problems (0 errors, 158 warnings)
  • yarn check-types (tsc --noEmit -p tsconfig.build.json) → exit 0
  • Diff is 1 file, +1 / −3, formatting only — no behavioural change.

Note (not changed here)

check-format is yarn prettier --list-different with no path argument, so under Prettier 3 it exits 0 with "couldn't infer a parser" and never actually checks anything. Happy to follow up with a --list-different . fix if wanted.

Summary by CodeRabbit

  • Style
    • Reformatted an internal type declaration. This change does not affect app behavior or the experience.

Collapse the CredentialFormatType union onto a single line so it satisfies
the prettier/prettier rule (printWidth 120). This was the only eslint error
in the repository and it has been failing the Validate CI job on main since

Signed-off-by: Ajay Jadhav <ajay@ayanworks.com>
#451 was merged.
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e6eb268a-6943-4910-abf8-a45a15a098ec
📥 Commits

Reviewing files that changed from the base of the PR and between 6b19172 and ece30cc.

📒 Files selected for processing: 1
  • src/controllers/types.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The pull request reformats CredentialFormatType as a single-line union. Its three credential format members remain unchanged.

Changes: Credential format type

Layer / File(s) Summary
Credential format declaration
src/controllers/types.ts
CredentialFormatType is formatted on one line. Its three union members are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Refactor

Suggested reviewers: shitrerohit

Merge Risk: ⚪ Minimal · up to ece30

This formatting-only change does not alter credential-format behavior, so no material user-facing merge risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the formatting-only change to the CredentialFormatType union and identifies the Prettier fix.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@ajile-in ajile-in self-assigned this Oct 19, 2026
@ankita-p17
ankita-p17 merged commit 62840c9 into main Oct 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants