Skip to content

fix: allow vc+sd-jwt issuance (route SdJwtVc through sd-jwt signing path) #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajile-in wants to merge 1 commit into from
+9 −2
Closed

fix: allow vc+sd-jwt issuance (route SdJwtVc through sd-jwt signing path) #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/utils/oid4vc-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export function getMixedCredentialRequestToCredentialMapper(): OpenId4VciCredent
agentContext,
authorization,
}) => {
const requestedFormat = credentialConfiguration.format as string
const issuanceMetadata = issuanceSession.issuanceMetadata
if (!issuanceMetadata?.['credentials']) throw new Error('credential payload is not provided')

Expand Down Expand Up @@ -98,7 +99,13 @@ export function getMixedCredentialRequestToCredentialMapper(): OpenId4VciCredent
)
}

if (credentialConfiguration.format === OpenId4VciCredentialFormatProfile.SdJwtDc) {
// Both `dc+sd-jwt` and `vc+sd-jwt` are signed with the same sd-jwt API. Credo's
// OpenId4VcIssuerService accepts `ClaimFormat.SdJwtDc` sign options for either
// configuration format and passes the format through as the credential `typ` header.
if (
credentialConfiguration.format === OpenId4VciCredentialFormatProfile.SdJwtDc ||
credentialConfiguration.format === OpenId4VciCredentialFormatProfile.SdJwtVc
) {
return handleSdJwtDcFormat(
agentContext,
credentialConfiguration,
Expand All @@ -125,7 +132,7 @@ export function getMixedCredentialRequestToCredentialMapper(): OpenId4VciCredent
) as any
}

throw new Error('Invalid request format ' + credentialConfiguration.format)
throw new Error('Invalid request format ' + requestedFormat)
}
}

Expand Down
Loading