Repository navigation
Testing: Start crate from testcontainers instead of cratedb-toolkit - #158
Merged
Merged
Conversation
testcontainers 4.15, the first release with a CrateDB container, needs Python 3.10, and both 3.8 and 3.9 are past their end of life.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The `cratedb` extra of testcontainers carries httpx, which its container module imports.
crate returns sub-columns whose value is null since 5.10.13 and 6.0.3.
florinutz
force-pushed
the
flo/157/testcontainers-upstream
branch
from
October 9, 2026 18:49
bd729a2 to
096fcf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commons-codec's tests start crate through cratedb-toolkit, and the toolkit's dynamodb, kinesis and mongodb extras depend on commons-codec, so a toolkit release that fails to install breaks this CI with nothing changed here (#157, crate/cratedb-toolkit#913).
The fixture now starts crate from the
CrateDBContainerclass of testcontainers, through a smallCrateDBTestAdapterintests/cratedb.pythat holds the SQL helpers the tests use. So thetestextra installstestcontainers[cratedb]>=4.15instead ofcratedb-toolkit[testing]. The fixture runs the crate version inCRATEDB_VERSION, nightly by default. A released version comes from the officialcrate:<version>image, because the release tags ofcrate/crateare amd64-only. testcontainers 4.15 needs Python 3.10, so thetestextra no longer installs on 3.8 and 3.9, and commons-codec drops both, which are past their end of life.One test (
test_normalize_list_of_objects) gets a new expectation, because crate returns sub-columns whose value is null since 5.10.13 and 6.0.3; earlier versions dropped them as a bug. No CI job ran this test: the job that selects it did not installtikray, so the old expectation went unnoticed. The vanilla job now installstikray.Closes #157.