Repository navigation
fix(sqlite): backport bundled WAL-reset fix for Crab - #78
Merged
Merged
Conversation
Use SQLite 3.51.3 to fix WAL-reset corruption. Preserve checked unsigned bindings and reject hook installation failures before SQL. Backport to the exact Cellule revision pinned by Crab.
This was referenced Oct 15, 2026
forhappy
marked this pull request as ready for review
October 15, 2026 07:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cellule currently bundles SQLite 3.49.1, which is affected by the upstream WAL-reset corruption race. Upgrade the ordinary published dependency to rusqlite 0.39 / SQLite 3.51.3 and preserve range-checked unsigned SQL bindings with
fallible_uint.This is the minimal backport for Crab's exact pinned Cellule revision
6ac8a03. It targets the preservedcodex/node-log-expiry-rotationbranch because current main has moved to the 0.2 Node Bundle representation. Crab must not import that unrelated storage/API migration as part of a SQLite safety fix. The same upgrade is forward-ported to current main in #79. No merge requested.Contract adaptation
DatabaseName::Mainwith upstream'sMAIN_DBat incremental blob I/O and read-only-root validation.Evidence and limits
737ae4a34738ffa0c3ff7f9bb18df914dd1cad163f28fd6b6e114a344fe6d618.cellule-sqlite-rustfs-compaction1.jsonandcellule-sqlite-rustfs-extra-receipt.json. The six opt-in cases above were skipped by the default suite; these runs explicitly qualify four. Two manual provider-cost/filesystem diagnostics remain unrun.Review evidence map
Is this the best fix? Use the maintained upstream SQLite fix and adapt its explicit API contracts. Global cache serialization or private SQLite patches would add ownership complexity and constrain throughput without delivering the same dependency correction.
Primary contracts: SQLite WAL-reset fix, rusqlite 0.39 release, feature authority.