Partial fix for #15048: shiftNegative for conditional value - #8884
Open
chrchr-github wants to merge 4 commits into
Open
chrchr-github wants to merge 4 commits into
chrchr-github wants to merge 4 commits into
Conversation
danmar
reviewed
Oct 1, 2026
| // a portability issue | ||
| const char* id = isLHS ? "shiftNegativeLHS" : "shiftNegative"; | ||
| const std::string msg = isLHS ? "Shifting a negative value is technically undefined behaviour" : "Shifting by a negative value is undefined behaviour"; | ||
| const Severity severity = isLHS ? Severity::portability : (v && v->errorSeverity() && !v->conditional ? Severity::error : Severity::warning); |
Collaborator
There was a problem hiding this comment.
This is an AI review. Take it with a grain of salt and feel free to reject it by resolving the comment.
getErrorMessages() calls this with v == nullptr, so --errorlist now reports shiftNegative as severity="warning" instead of severity="error". I checked this with a build of the PR. Tools that use the error list (GUI, docs, severity mappings) would see the downgrade even though a known negative shift is still an error. Maybe treat a missing value as the non-conditional case:
Suggested change
| const Severity severity = isLHS ? Severity::portability : (v && v->errorSeverity() && !v->conditional ? Severity::error : Severity::warning); | |
| const Severity severity = isLHS ? Severity::portability : (!v || (v->errorSeverity() && !v->conditional) ? Severity::error : Severity::warning); |
Apart from that, the new severity matches how zerodiv/zerodivcond handle the same patterns. I compared with int d = 0; if (b) return i; return i / d;.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.