Repository navigation
fix: drop stale test that required network_for_floating_ip - #30
Merged
Merged
Conversation
Commit 8ae7cc1 made 'network_for_floating_ip' optional in create_vm, but a test asserting the old "field is required" die was merged in parallel from another branch. Neither branch saw the other, so main went red on every CI job. Without a floating network, create_vm now runs the whole create flow, so the test hit unmocked endpoints and died on "Connection refused" instead of the expected message. Remove the stale assertion and add t/create-vm-no-floating-ip.t, which covers the path nothing tested: create_vm succeeds with no floating network, returns the server, and never asks for a floating IP. That test fails if the requirement is reintroduced. Also ignore local/, the cpm dependency directory CI already builds. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 8ae7cc1 made 'network_for_floating_ip' optional in create_vm, but a test asserting the old "field is required" die was merged in parallel from another branch. Neither branch saw the other, so main went red on every CI job.
Without a floating network, create_vm now runs the whole create flow, so the test hit unmocked endpoints and died on "Connection refused" instead of the expected message.
Remove the stale assertion and add t/create-vm-no-floating-ip.t, which covers the path nothing tested: create_vm succeeds with no floating network, returns the server, and never asks for a floating IP. That test fails if the requirement is reintroduced.
Also ignore local/, the cpm dependency directory CI already builds.