Skip to content

fix: create_vm robustness and cleanup #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 2 commits into from
Sep 11, 2026
Merged

fix: create_vm robustness and cleanup #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
712bfc6
fix: create_vm robustness — image null-check, redundant condition, te…
Koan-Bot Apr 9, 2026
2985fe3
chore: remove dead .whitesource configuration
Koan-Bot Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .whitesource
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions lib/OpenStack/MetaAPI.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ sub create_vm {
}
$image //= $self->image_from_name($opts{image});

die "Cannot find image for id/name '$opts{image}'"
unless ref $image eq 'HASH' && _looks_valid_id($image->{id});

my $security_group =
$self->look_by_id_or_name(security_groups => $opts{security_group});

Expand Down
69 changes: 35 additions & 34 deletions t/xtra-create-vm.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,27 @@ ok $api, "got one api object" or die;
qr{Cannot find 'networks' for id/name '$FLOATING_IP_NETWORK'},
"fail when using an unkown network");

note "attempt 2";
note "attempt: image not found";

$FLOATING_IP_NETWORK = 'net2';

# mock image lookup to return empty results
mock_get_request(
'http://127.0.0.1:9292/v2/images/170fafa5-1329-44a3-9c27-9bb77b77206d',
application_json('{}'),
);
mock_get_request(
'http://127.0.0.1:9292/v2/images',
application_json('{"images": []}'),
);

like(
dies { $create_vm->() },
qr{Cannot find image for id/name '$IMAGE_UID'},
"fail when image is not found");

note "attempt: server creation";

mock_get_request(
'http://127.0.0.1:9292/v2/images/170fafa5-1329-44a3-9c27-9bb77b77206d',
application_json(json_imageid()),
Expand Down Expand Up @@ -476,41 +493,25 @@ JSON
}

sub json_imageid {

# Glance v2 API returns a flat image object (not wrapped in {image: ...})
return <<'JSON';
{
"image": {
"OS-DCF:diskConfig": "AUTO",
"OS-EXT-IMG-SIZE:size": "74185822",
"created": "2011-01-01T01:02:03Z",
"id": "70a599e0-31e7-49b7-b260-868f441e862b",
"links": [
{
"href": "http://openstack.example.com/v2/6f70656e737461636b20342065766572/images/70a599e0-31e7-49b7-b260-868f441e862b",
"rel": "self"
},
{
"href": "http://openstack.example.com/6f70656e737461636b20342065766572/images/70a599e0-31e7-49b7-b260-868f441e862b",
"rel": "bookmark"
},
{
"href": "http://glance.openstack.example.com/images/70a599e0-31e7-49b7-b260-868f441e862b",
"rel": "alternate",
"type": "application/vnd.openstack.image"
}
],
"metadata": {
"architecture": "x86_64",
"auto_disk_config": "True",
"kernel_id": "nokernel",
"ramdisk_id": "nokernel"
},
"minDisk": 0,
"minRam": 0,
"name": "fakeimage7",
"progress": 100,
"status": "ACTIVE",
"updated": "2011-01-01T01:02:03Z"
}
"id": "70a599e0-31e7-49b7-b260-868f441e862b",
"name": "fakeimage7",
"status": "active",
"visibility": "public",
"min_disk": 0,
"min_ram": 0,
"size": 74185822,
"container_format": "bare",
"disk_format": "raw",
"created_at": "2011-01-01T01:02:03Z",
"updated_at": "2011-01-01T01:02:03Z",
"schema": "/v2/schemas/image",
"self": "/v2/images/70a599e0-31e7-49b7-b260-868f441e862b",
"file": "/v2/images/70a599e0-31e7-49b7-b260-868f441e862b/file",
"tags": []
}
JSON
}
Expand Down