Repository navigation
fix(ingest): fold attachment bodies in a batch onto their prompt - #67
Merged
Merged
Conversation
A batch sent to /v1/ingest/{source} went straight to record_ingests, so an
attachment body inside one (a replayed spool can carry it) was projected as
an event instead of folding onto its prompt as it does when sent alone. The
batch route now splits at attachment bodies, keeping order; each run of
other bodies stays one write transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch sent to
/v1/ingest/{source}went straight torecord_ingests, so an attachment body inside it was projected as an event instead of folding onto its prompt the way it does when sent alone. A replayed spool batches consecutive events, so an attachment spooled during an outage hit this. The import poster already sends attachments alone, so imports weren't affected.The batch route now splits at attachment bodies, keeping order. Each run of other bodies between them is still one write transaction.
Independent of the #64 → #65 → #66 stack (based on main).
Test:
test_batch_folds_attachments_onto_their_prompt. Suite: 604 passed.🤖 Generated with Claude Code