Repository navigation
Support encrypted media upload and verified download - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide encrypted attachment upload and verified download without opening another crypto store. Uploads contain only ciphertext, and the caller sends the returned metadata using its existing encrypted session. Downloads verify integrity before replacing their destination.
The existing
mx_send_media()now checks room encryption before upload and refuses a plaintext send into an encrypted room, including when the state lookup fails.Validation: 981 assertions pass with isolated state, including transport fakes that inspect uploaded bytes and metadata, tampered-download protection, and the plaintext refusal. CI pins mx.crypto 0.2.2.2 and requires the attachment tests. Version 0.2.1.4. Depends on cornball-ai/mx.crypto#10.