Repository navigation
Say when a cleartext client drops an encrypted room's events - #31
Open
TroyHernandez wants to merge 2 commits into
Open
TroyHernandez wants to merge 2 commits into
TroyHernandez wants to merge 2 commits into
Conversation
Contributor
Author
|
Verification for a9ebfe6 + 5fb8a62:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes a silent failure visible: a Matrix client built without
e2eenow says so when an encrypted room's events reach it.What
chat_poll()on a client withe2ee = FALSEemits a message naming the room the first time it sees anm.room.encryptedevent there, once per room for the life of the client:An
e2eeclient decrypts those events instead and never raises it. Thee2eeparameter's documentation says what happens when it is off.Why
A cleartext client in an encrypted room receives
m.room.encryptedevents it cannot read, and the text extractor skips them. Nothing in the poll mentioned them, so a bot invited into such a room looked dead: it joined, and every message after that vanished without a line in its log, while it kept answering in its unencrypted rooms. Clients enable encryption on private rooms by default, so this is an easy state to end up in. One message in the log the operator is already reading turns a dead-bot hunt into a config change.Verification
test_matrix.R: a seamed poll over one encrypted and one cleartext room says it once, names only the encrypted room, stays quiet on the next poll of the same room, speaks again for a room first seen encrypted later, and says nothing for ane2eeclient or an empty sync.tinypkgr::check(): results in the first comment.