Repository navigation
Conversation
swhitt
force-pushed
the
feat/tsa-request-headers
branch
2 times, most recently
from
October 29, 2026 15:28
76ab431 to
2762614
Compare
swhitt
marked this pull request as ready for review
October 29, 2026 15:33
swhitt
force-pushed
the
feat/tsa-request-headers
branch
from
October 29, 2026 15:35
2762614 to
9ba78da
Compare
swhitt
commented
Oct 29, 2026
|
|
||
| ## Time-stamping | ||
|
|
||
| Set the timestamp authority URL with `ta_url` in the manifest JSON, `tsa_url` in the settings file or `--signer-info` response, or the `C2PA_TA_URL` environment variable. `C2PA_TA_URL` is used only when no URL is set elsewhere. |
Author
There was a problem hiding this comment.
The tsa_url vs ta_url split is pre-existing. c2pa-rs settings and --signer-info use tsa_url, the manifest JSON and env vars use ta_. I just matched each one. Probably not worth renaming here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adds TSA request headers so we can sign against a TSA that needs auth. Non-secret headers go in
ta_headersnext tota_urlin the manifest JSON, secrets go inC2PA_TA_HEADERS(oneName: valueper line), same split asta_url/C2PA_TA_URL. Both get sent on the claim and ingredient timestamps for every signer type.Content-Typeis rejected since c2pa sets it, and a bad env line errors without echoing the value.Needs
Signer::ocsp_valsand contentauth/c2pa-rs#2762, both in the c2pa bump onmain(67d93ed). Rebased on that. 10 integration tests fail onmainafter the bump (assertion.action.ingredientMismatch), same 10 here, so not from this.Relates to contentauth/c2pa-rs#2096.
Validation:
cargo test --test integrationagainst67d93ed. 3 new tests against a mock TSA (headers sent,Content-Typerejected, bad env line doesn't leak) all pass.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.