hugetlb: reject page sizes containing path separators - #400
Open
justmorpheus wants to merge 1 commit into
Open
justmorpheus wants to merge 1 commit into
justmorpheus wants to merge 1 commit into
Conversation
The hugepage size from LinuxResources.HugepageLimits is used to build the hugetlb limit filename. A value containing path separators makes the resulting path resolve outside of the cgroup directory, and the write silently lands there. Return an error instead. For cgroup v2 the check is done in Value.write so it covers every filename written to the unified hierarchy. Valid page sizes (e.g. "2MB", "1GB") are unaffected. This matches the hardening applied in runc (opencontainers/runc#4103). Signed-off-by: divyanshu <86191568+justmorpheus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hugepage size from LinuxResources.HugepageLimits is used to build the hugetlb limit filename. A value containing path separators makes the resulting path resolve outside of the cgroup directory, and the write silently lands there.
Return an error instead. For cgroup v2 the check is done in Value.write so it covers every filename written to the unified hierarchy. Valid page sizes (e.g. "2MB", "1GB") are unaffected.
Follow-up to the closed advisory GHSA-vg8r-xxjh-q4ww and this also matches the hardening applied in runc (opencontainers/runc#4103).
Tests added for both cgroup v1 and v2