Repository navigation
Make the PR checklist a friendly reminder, not a gate - #104
Merged
Merged
Conversation
The checklist check now warns about unticked boxes instead of failing, so a first-time contributor never sees a red X over paperwork. The template drops to three boxes; the real ask stays a test that fails without a bug fix. Screenshots and Assisted-by become nice to have, and a maintainer may finish small leftovers with the contributor kept as co-author. The six test checks still block merging. Assisted-by: Claude Code
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by CH · project thread
What was wrong, what you changed, how you checked:
The checklist rules made it harder for first-time contributors. The
checklistcheck put a red X on a PR over paperwork, and a one-line change (#90) got three asks. This PR:checklistnever fails now. It lists any unticked box as a yellow warning. The six test checks still block merging.bite live), and pytest/CI green. Screenshots andAssisted-bymove to "nice to have, never required".Assisted-bycan go in the commit or the PR description, and that a maintainer may finish small leftovers for you and keep you as co-author.Ran
python -m pytest: 91 passed. With thebot/pr_checklist.pychange taken out, 3 checklist tests fail.Fixes # n/a (no issue, small change)
python -m pytestpasses, and CI is green.Generated by Claude Code