Skip to content

Make the PR checklist a friendly reminder, not a gate - #104

Merged
connabyss merged 1 commit into
mainfrom
claude/project-thread-7efqyu
Nov 1, 2026
Merged

connabyss merged 1 commit into
mainfrom
claude/project-thread-7efqyu

Conversation

@connabyss

Copy link
Copy Markdown
Owner

Requested by CH · project thread

What was wrong, what you changed, how you checked:

The checklist rules made it harder for first-time contributors. The checklist check put a red X on a PR over paperwork, and a one-line change (#90) got three asks. This PR:

  • checklist never fails now. It lists any unticked box as a yellow warning. The six test checks still block merging.
  • The template goes from 5 boxes to 3: linked issue (small fixes can skip it), a test that fails without the change for bug fixes (with a pointer to bite live), and pytest/CI green. Screenshots and Assisted-by move to "nice to have, never required".
  • CONTRIBUTING and AGENTS.md now say the same. They also say Assisted-by can go in the commit or the PR description, and that a maintainer may finish small leftovers for you and keep you as co-author.

Ran python -m pytest: 91 passed. With the bot/pr_checklist.py change taken out, 3 checklist tests fail.

Fixes # n/a (no issue, small change)

  • It links the issue it fixes (a small fix can skip this).
  • For a bug fix: a test that fails without the change and passes with it.
  • python -m pytest passes, and CI is green.

Generated by Claude Code

The checklist check now warns about unticked boxes instead of failing, so a
first-time contributor never sees a red X over paperwork. The template drops
to three boxes; the real ask stays a test that fails without a bug fix.
Screenshots and Assisted-by become nice to have, and a maintainer may finish
small leftovers with the contributor kept as co-author. The six test checks
still block merging.

Assisted-by: Claude Code
@connabyss connabyss self-assigned this Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Bite ✅ Bite-proof. Nice work.

Bite took each change out, one at a time, and a test noticed every time. If one breaks later, that test will warn you.

Badge for your README: [![Bite-proof ✅](https://img.shields.io/badge/Bite--proof-%E2%9C%85-black)](https://github.com/connabyss/bite)

  • ✅ The tests test_the_step_never_fails_and_warns_about_the_unticked_box and 1 more noticed it was gone. If this change breaks later, they will warn you.
    Commit 327abf9e: “Make the PR checklist a friendly reminder, not a gate”
How Bite checks

Bite asks one question about each change: if it disappeared, would any test notice? It takes the change out, runs your tests, and puts it back. What is Bite?

@connabyss
connabyss merged commit 2cb15b7 into main Nov 1, 2026
8 checks passed
@connabyss
connabyss deleted the claude/project-thread-7efqyu branch November 1, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants