Skip to content

refactor: drop test-only exports after the test consolidation - #646

Merged
omridevk merged 12 commits into
mainfrom
tests-phase2-exports
Oct 30, 2026
Merged

omridevk merged 12 commits into
mainfrom
tests-phase2-exports

Conversation

@omridevk

@omridevk omridevk commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Test consolidation, phase 2: drop the exports that existed only for tests. Follows the phase 1 folds (#628 to #643).

18 exports removed across nine packages and apps/site. Where a test still needed the value it moved into that package's test helper or the test itself; where nothing consumed it, it is deleted. Each candidate was checked with fallow dead-code --trace and a repo-wide grep, since fallow attributes imports that go through a package's index to the index.

  • mascot: curveControlPoints unexported.
  • ui-kit-system: SkinSchemeAnchorName unexported; test/wcag.ts derives it from SkinColorPairs.
  • db: CHAT_IMPORT_KEY, CHAT_MIGRATION_NAMESPACE unexported, inlined in the test.
  • page: hashCssText unexported.
  • extension-page: pageVerbMutates, pageVerbMirrors deleted (no consumers).
  • cli: FoundSelections unexported; the helper derives it from PlanPrompts.
  • extension-ios: bridgeMessageSchemasByType moved into the test (the schemas it lists stay exported); RunOptions unexported, derived in the test.
  • extension-recorder: VIEWER_LEASE_MS unexported.
  • extension-whiteboard: ELEMENT_WRITE_THROTTLE_MS moved to the canvas test helper; changeOf deleted (no consumers).
  • apps/site: pairText, canonicalUrlFromPathname, ORGANIZATION_ID, WEBSITE_ID unexported.

39 candidates skipped on purpose: public entries of published packages (protocol, mascot effects, harness-init, extension, extension-compiler, recorder server), symbols other packages' tests import through the package index (grab, contract, tools, extension-page), and internal functions that src calls and the tests exercise directly (ui-kit-system autosize, page grab-text, cli init steps, try cli, plugin extensions entry, ios bridge). Owner decision: createMessageStore, createMetadataStore (the @tanstack/ai-persistence adapters) and sessionHistoryFor had no src caller on main or on #625, so they are deleted with their conformance suite and the now-unused @tanstack/ai-persistence dependency of db. The legacy chat-thread import still runs on every openDb, so its seven cases are kept and now assert through readThread and drizzle selects instead of the deleted stores.

Gates: per-package build and serial test gate green for all ten packages (mascot 89, ui-kit-system 239, db 40, page 68, extension-page 67, cli 279, ios 188, recorder 58, whiteboard 62, site 7), typecheck:affected 77/77, pnpm lint, format check, fallow audit clean. Changeset: patch for the nine published packages.

🤖 Generated with Claude Code

omridevk and others added 10 commits October 30, 2026 22:55
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… wcag helper

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…irrors

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ons into the test

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…er, delete unused changeOf

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ea663c2e-8a43-4861-8047-24bdbcfa61b7
Commits

Reviewing files that changed from the base of the PR and between eaacc9c and d8d9a10.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 28
  • .changeset/tests-phase2-exports.md
  • apps/site/src/lib/pair-text.ts
  • apps/site/src/lib/site-urls.ts
  • apps/site/src/lib/structured-data.ts
  • packages/cli/src/init/wizard.ts
  • packages/cli/test/cli.test.ts
  • packages/cli/test/helpers.ts
  • packages/db/package.json
  • packages/db/src/chat-thread-import.ts
  • packages/db/src/index.ts
  • packages/db/src/message-store.ts
  • packages/db/src/metadata-store.ts
  • packages/db/src/run-queries.ts
  • packages/db/test/db.test.ts
  • packages/extensions/ios/src/server/simctl-runner.ts
  • packages/extensions/ios/src/shared/bridge.ts
  • packages/extensions/ios/test/ios.test.ts
  • packages/extensions/page/src/shared/defs.ts
  • packages/extensions/recorder/src/server/capture-control.ts
  • packages/extensions/whiteboard/src/client/whiteboard-collection.ts
  • packages/extensions/whiteboard/src/shared/rows.ts
  • packages/extensions/whiteboard/test/canvas-it-helpers.ts
  • packages/extensions/whiteboard/test/whiteboard.test.ts
  • packages/mascot/src/core/path.ts
  • packages/page/src/css-bundle.ts
  • packages/ui-kit-system/src/skin-contract.ts
  • packages/ui-kit-system/test/ui-kit-system.browser.test.tsx
  • packages/ui-kit-system/test/wcag.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

omridevk and others added 2 commits October 30, 2026 23:06
…sionHistoryFor

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…drizzle

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@omridevk
omridevk merged commit 71a7483 into main Oct 30, 2026
45 of 47 checks passed
@omridevk
omridevk deleted the tests-phase2-exports branch October 30, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant