Repository navigation
refactor: drop test-only exports after the test consolidation - #646
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… wcag helper Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…irrors Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ons into the test Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…er, delete unused changeOf Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…sionHistoryFor Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…drizzle Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test consolidation, phase 2: drop the exports that existed only for tests. Follows the phase 1 folds (#628 to #643).
18 exports removed across nine packages and apps/site. Where a test still needed the value it moved into that package's test helper or the test itself; where nothing consumed it, it is deleted. Each candidate was checked with
fallow dead-code --traceand a repo-wide grep, since fallow attributes imports that go through a package's index to the index.curveControlPointsunexported.SkinSchemeAnchorNameunexported;test/wcag.tsderives it fromSkinColorPairs.CHAT_IMPORT_KEY,CHAT_MIGRATION_NAMESPACEunexported, inlined in the test.hashCssTextunexported.pageVerbMutates,pageVerbMirrorsdeleted (no consumers).FoundSelectionsunexported; the helper derives it fromPlanPrompts.bridgeMessageSchemasByTypemoved into the test (the schemas it lists stay exported);RunOptionsunexported, derived in the test.VIEWER_LEASE_MSunexported.ELEMENT_WRITE_THROTTLE_MSmoved to the canvas test helper;changeOfdeleted (no consumers).pairText,canonicalUrlFromPathname,ORGANIZATION_ID,WEBSITE_IDunexported.39 candidates skipped on purpose: public entries of published packages (protocol, mascot effects, harness-init, extension, extension-compiler, recorder server), symbols other packages' tests import through the package index (grab, contract, tools, extension-page), and internal functions that src calls and the tests exercise directly (ui-kit-system autosize, page grab-text, cli init steps, try cli, plugin extensions entry, ios bridge). Owner decision:
createMessageStore,createMetadataStore(the@tanstack/ai-persistenceadapters) andsessionHistoryForhad no src caller on main or on #625, so they are deleted with their conformance suite and the now-unused@tanstack/ai-persistencedependency of db. The legacy chat-thread import still runs on everyopenDb, so its seven cases are kept and now assert throughreadThreadand drizzle selects instead of the deleted stores.Gates: per-package build and serial test gate green for all ten packages (mascot 89, ui-kit-system 239, db 40, page 68, extension-page 67, cli 279, ios 188, recorder 58, whiteboard 62, site 7),
typecheck:affected77/77,pnpm lint, format check, fallow audit clean. Changeset: patch for the nine published packages.🤖 Generated with Claude Code