Skip to content

error output: report a failure inside a subshell once #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MickLesk merged 1 commit into from
Oct 23, 2026
Merged

error output: report a failure inside a subshell once #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/error_handler.func
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,13 @@ error_handler() {

[[ "$exit_code" -eq 0 ]] && return 0

# set -E hands the ERR trap (which passes no arguments) to $(...) and ( ) too.
# The calling shell fails on the same error and reports it, so reporting here
# as well printed it twice.
if ((BASH_SUBSHELL > 0 && $# == 0)); then
exit "$exit_code"
fi

# Telemetry reads these for the "where"
FAILED_COMMAND="$command"
FAILED_LINE="$line_number"
Expand Down
Loading