Repository navigation
Announce failed query executions without changing exceptions - #337
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query execution failures now announce
onQBExecuteExceptionwith the original exception, execution context, and elapsed time, then rethrow that same exception. Failure observers and their diagnostic logger cannot replace it; pretend queries and successful execution hooks remain compatible. The hook reuses the capability flag initialized bypreQBExecutewithout repeating the param.Exception-preservation tests compare native exception objects by identity and CFML catch structs by their contents. Structural comparison cannot iterate native BoxLang exceptions, while CFML engines can produce separate catch wrappers for the same rethrown exception. Both representations retain the original failure checks.
Validation: all four focused TestBox specs pass on native BoxLang 1.18.0+66, with bx-compat-cfml 1.40.0 enabled, and on Lucee 6.2.8.20. They cover original exception preservation, observer diagnostics, diagnostic logger failure isolation, processState compatibility, and pretend-query behavior. Formatting and whitespace checks passed. The complete qb suite and engine matrix were not rerun locally for this assertion-only follow-up.
Documentation lives in ortus-docs/qb-docs#46; this code PR contains no README documentation addition.
This preview supplies caught-query failure coverage for coldbox-modules/sentry#49. It is based on the verified v14.0.2 commit and uses version 14.0.3-alpha.1 for isolated consumer validation.