Skip to content

Address several flake8 issues #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cottsay wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Address several flake8 issues #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion colcon_python_setup_py/package_augmentation/python_setup_py.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def augment_package( # noqa: D102
desc.dependencies)

def getter(env):
nonlocal setup_py
return get_setup_information(setup_py, env=env)

desc.metadata['get_python_setup_options'] = getter
Expand Down
7 changes: 3 additions & 4 deletions colcon_python_setup_py/package_identification/python_setup_py.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
with suppress(ImportError):
# needed before importing distutils
# to avoid warning introduced in setuptools 49.2.0
import setuptools
import distutils.core
import os
import setuptools # noqa: I100
import distutils.core # noqa: I100, I201, I202
import os # noqa: I100, I201, I202
from pathlib import Path
import runpy
import subprocess
Expand Down Expand Up @@ -238,7 +238,6 @@ def get_setup_information(setup_py, *, env=None):
:return: dictionary of data describing the package.
:raise: RuntimeError if the setup script encountered an error
"""
global _setup_information_cache
if env is None:
env = os.environ
if 'DISTUTILS_DEBUG' in env:
Expand Down
Loading