Unify temporary directory allocation strategy in tests - #64
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 51.00% 51.00%
=======================================
Files 3 3
Lines 149 149
Branches 23 23
=======================================
Hits 76 76
Misses 67 67
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cottsay
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the upstream unification in
colcon/colcon-core#729, this PR refactors the test suite to use the moderntmp_pathfixture (which provides apathlib.Pathobject) instead of mixing multiple temporary directory strategies.Specifically, this package previously used:
TemporaryDirectorymanagement (intest/test_package_identification_python_setup_py.py)This refactor:
test/conftest.pycompatibility fixture fortmp_path(supporting older pytest versions, such as those on Enterprise Linux 8).test/test_package_identification_python_setup_py.pyto accept and utilize thetmp_pathfixture, removing the manual context manager.globalreferences intest/test_spell_check.pyto prevent style guide validation errors on newer flake8 configurations.test/spell_check.wordsto include words introduced by the compatibility fixture (isdigit,itertools,linux,takewhile,tmpdir) and removes the now-unusedtempfile.Reference
Specifics
colcon-python-setup-pyrelied entirely on manualTemporaryDirectorycontext manager blocks.🤖 Assisted by Gemini