feat(explore): find code by literal keys and flags - #1841
Open
bompus wants to merge 2 commits into
Open
Conversation
bompus
marked this pull request as ready for review
September 11, 2026 05:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A query naming a storage key such as
draft.pickcurrently relies on symbol-name search even when the relevant functions contain that exact string. Capture bounded identifier-shaped literals, persist their enclosing symbols, and use exact matches to seed context and preserve holder files in explore output. This covers WASM extraction, native extraction, and deferred native-buffer decoding.The schema migration creates the new side table without backfilling source content. Existing indexes receive a rebuild recommendation; full indexing populates the table. Capture is deliberately bounded to identifier-shaped strings, 32 distinct literals per node and 24 query holders. It uses source scanning, so qualifying strings in comments can also match; these are retrieval hints, not inferred graph edges.
Validation on the upstream-based branch: application and native-kernel builds passed; 101 tests across six native suites and 43 tests across four WASM suites passed. Three additional compiled-index regressions passed in native worker, native main-thread, and WASM worker modes, covering fresh indexing, unchanged re-indexing, migration backfill, deleted-file cleanup, and same-line ownership after non-ASCII text. Tests cover lookup, holder ranking, index lifecycle, migration replay, deferred native persistence, and the rebuild recommendation. No full-suite, cross-platform, or agent A/B claim.