Skip to content

Support gRPC default authority - #358

Open
chenrui333 wants to merge 1 commit into
coinbase:masterfrom
chenrui333:rchen.grpc-default-authority
Open

Support gRPC default authority#358
chenrui333 wants to merge 1 commit into
coinbase:masterfrom
chenrui333:rchen.grpc-default-authority

Conversation

@chenrui333

Copy link
Copy Markdown

Summary

  • add a default_authority connection option backed by grpc.default_authority
  • apply the authority to both workflow and operator service channels
  • document absolute resolver targets with a separate TLS/HTTP2 authority

This allows clients to use a DNS target with a trailing dot while preserving
the certificate and HTTP/2 authority of the canonical undotted hostname.

Tests

  • bundle exec rspec spec/unit/lib/temporal/grpc_spec.rb -e default_authority
  • full suite adds no failures relative to current master under Ruby 3.2.2

Signed-off-by: Rui Chen <rui@chenrui.dev>
context "when default_authority is passed" do
let(:options) { { default_authority: "temporal.example.com" } }

it "passes the authority to the workflow service channel" do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants