Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CrateFilter::AllCratesnever runs the plugin on dependencies.cli_mainalways setsRUSTC_WORKSPACE_WRAPPER(cli.rs:46), and Cargo applies that wrapper only to workspace members, so dependencies are compiled by plain rustc and never reach therun_on_all_cratescheck in the driver (driver.rs:134-141).For
AllCratesthe CLI now setsRUSTC_WRAPPERinstead, whileOnlyWorkspaceandCrateContainingFilekeepRUSTC_WORKSPACE_WRAPPER. The driver doesn't need to change, because Cargo passes the rustc path as the first argument with either variable, andwrapper_modealready strips it. WithRUSTC_WRAPPERthe plugin also runs on build scripts and proc-macro crates of dependencies, and a wrapper the user set themselves (sccache, for example) gets replaced duringAllCratesruns.Tests
dependencytest onworkspaces/deps, a crate whose path dependency is not a workspace member. On main it fails because only the root crate's items are printed. With this change it passes.cargo clippy --all-features -- -D warnings,cargo test --all-features -- --test-threads=1,cargo docwith-D warningsandcargo fmt --all --checkpass locally on nightly-2026-05-01 and in CI on my fork: https://github.com/konstde00/rustc_plugin/actions/runs/40108212927cargo print-all-itemson a new crate that depends onitoaprinted 3 items before and 69 after, including itoa'sBufferandInteger.Fixes #19