Repository navigation
chore(provider-email): bump nodemailer to 10 with correct workspace lockfile - #1291
Merged
Merged
Conversation
Refs #1279 - provider-email: nodemailer ^10.1.4; @types/nodemailer removed because v10 ships its own declarations (Node >=20). - provider-email: import SendMailOptions as a named type; nodemailer 10 no longer exposes the `nodemailer.SendMailOptions` namespace. - manager: declare @builderbot/bot as workspace:* devDependency so a non-frozen install keeps link:../bot instead of registry 1.4.4.
Refs #1279 nodemailer@10 requires Node >= 20. Declaring engines makes that floor visible at install time instead of failing at runtime on Node 18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Que tipo de Pull Request es?
Descripción
Replace the Dependabot nodemailer bump with a lockfile that is actually correct, and fix the drift at its root.
Supersedes #1279 (which is currently
CONFLICTING, hasTests: CANCELLED, and resolves@builderbot/botto registry1.4.4instead oflink:../bot).Cambios
packages/provider-email/package.jsonnodemailer^6.10.1→^10.1.4;@types/nodemailerremoved (v10 ships its own declarations)packages/provider-email/src/email/core.tsnodemailer.SendMailOptions→ namedSendMailOptionsimport (v10 no longer exposes the namespace)packages/manager/package.json@builderbot/botadded asworkspace:*devDependency; peer range>=1.0.0unchangedpnpm-lock.yamlmanagerresolveslink:../botagain and no registry snapshot of the core is left.prettierignorepnpm-lock.yamlexcluded — Prettier was rewriting 50k lockfile lines on every commit that touched itPor qué el
managercambiapackages/managerdeclared@builderbot/botonly as a peer (>=1.0.0). Any non-frozenpnpm installtherefore resolved it against the registry (1.4.4), silently replacing the workspace link — which is exactly the regression that made #1279 unmergeable. Declaring it as aworkspace:*devDependency makes the local link explicit and stable.devDependenciesare not published.Verificación ejecutada
provider-emailjestmanageruvupnpm --filter @builderbot/bot buildpnpm --filter @builderbot/provider-email buildpnpm install --frozen-lockfile --lockfile-onlyNota de compatibilidad
nodemailer@10declaresengines.node >= 20. The repository still accepts Node18.17. This PR therefore declaresengines.node: ">=20"inpackages/provider-email/package.json, so npm/pnpm warn at install time instead of failing silently at runtime on Node 18.Fuera de alcance
No other dependency was bumped.
#1279should be closed or left to its author as superseded — this PR does not close it.Checklist
--frozen-lockfileTestsandTemplates in syncboth passed