Skip to content

chore(provider-email): bump nodemailer to 10 with correct workspace lockfile - #1291

Merged
leifermendez merged 2 commits into
builderbotfrom
chore/nodemailer-10
Nov 18, 2026
Merged

leifermendez merged 2 commits into
builderbotfrom
chore/nodemailer-10

Conversation

@leifermendez

@leifermendez leifermendez commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Que tipo de Pull Request es?

  • Mejoras
  • Bug
  • Docs / tests

Descripción

Replace the Dependabot nodemailer bump with a lockfile that is actually correct, and fix the drift at its root.

Supersedes #1279 (which is currently CONFLICTING, has Tests: CANCELLED, and resolves @builderbot/bot to registry 1.4.4 instead of link:../bot).

Cambios

Archivo Cambio
packages/provider-email/package.json nodemailer ^6.10.1 → ^10.1.4; @types/nodemailer removed (v10 ships its own declarations)
packages/provider-email/src/email/core.ts nodemailer.SendMailOptions → named SendMailOptions import (v10 no longer exposes the namespace)
packages/manager/package.json @builderbot/bot added as workspace:* devDependency; peer range >=1.0.0 unchanged
pnpm-lock.yaml Regenerated with pnpm; manager resolves link:../bot again and no registry snapshot of the core is left
.prettierignore pnpm-lock.yaml excluded — Prettier was rewriting 50k lockfile lines on every commit that touched it

Por qué el manager cambia

packages/manager declared @builderbot/bot only as a peer (>=1.0.0). Any non-frozen pnpm install therefore resolved it against the registry (1.4.4), silently replacing the workspace link — which is exactly the regression that made #1279 unmergeable. Declaring it as a workspace:* devDependency makes the local link explicit and stable. devDependencies are not published.

Verificación ejecutada

Check Resultado
provider-email jest 83/83 (3 suites)
manager uvu 267/267
pnpm --filter @builderbot/bot build OK (types resolved for the workspace)
pnpm --filter @builderbot/provider-email build OK
pnpm install --frozen-lockfile --lockfile-only OK — lockfile consistent with manifests
Lockfile size 22,769 lines vs 22,794 at base — 47 changed lines, no mass reindent
Full pre-push suite (all 29 projects) passed

Nota de compatibilidad

nodemailer@10 declares engines.node >= 20. The repository still accepts Node 18.17. This PR therefore declares engines.node: ">=20" in packages/provider-email/package.json, so npm/pnpm warn at install time instead of failing silently at runtime on Node 18.

Fuera de alcance

No other dependency was bumped. #1279 should be closed or left to its author as superseded — this PR does not close it.

Checklist

  • Tests and build run locally on this tree
  • Lockfile verified with --frozen-lockfile
  • CI at this PR head — run 44178207686: Tests and Templates in sync both passed

Refs #1279

- provider-email: nodemailer ^10.1.4; @types/nodemailer removed because v10
  ships its own declarations (Node >=20).
- provider-email: import SendMailOptions as a named type; nodemailer 10 no
  longer exposes the `nodemailer.SendMailOptions` namespace.
- manager: declare @builderbot/bot as workspace:* devDependency so a
  non-frozen install keeps link:../bot instead of registry 1.4.4.
@leifermendez leifermendez added the dependencies Pull requests that update a dependency file label Nov 17, 2026
Refs #1279

nodemailer@10 requires Node >= 20. Declaring engines makes that floor visible
at install time instead of failing at runtime on Node 18.
@leifermendez
leifermendez merged commit afe8881 into builderbot Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant