Repository navigation
fix(security)!: harden storage, media, tenant lifecycle and webhooks - #1290
Merged
Merged
Conversation
Refs #1289 BREAKING CHANGE: inbound Chatwoot webhooks require the matching webhookSecret, original raw body and valid signing headers. See the plugin README for migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Que tipo de Pull Request es?
Descripción
Harden six audited boundaries with one coherent commit per correction, keeping regression tests and documentation alongside each behavior change.
Linked issues
Refs #1284, #1285, #1286, #1287, #1288, #1289.
All six tracking issues have maintainer-authorized
status:approved. These references intentionally do not automatically close issues.Changes
e454a37dapi.twilio.comURLs, without URL credentials or custom ports8fdf9214c9feb0adfb8069a7b3ff8dc256927bf8Breaking security migration
Inbound Chatwoot webhooks now require
webhookSecret, the original request bytes, and valid signing headers. Unsigned/invalid automatic requests receive HTTP401. ManualhandleWebhookcallers must pass the verification argument. Outbound-only mirroring can still omit inbound webhook options.Create or reuse the actual webhook in Chatwoot, copy that webhook's signing secret (not the API token), and configure the bot before restarting. Automatic webhook registration does not provision/retrieve its signing secret. See
packages/plugins/chatwoot/README.md.Verification observed during implementation
Behavior-first regressions were observed failing before their fixes, then passing. Commands used installed UVU/Jest binaries without installing dependencies.
database-mysqlprovider-twilioprovider-emailmanagerbotplugins/chatwootgit diff --checkpassed..git, Lerna/Nx successfully ran tests for all 29 projects and their two dependency tasks. The initial.gitworktree attempt failed Jest discovery; one corrected attempt was explicitly authorized. No hook bypass or dependency installation was used.56927bf8, attempt 2: Templates in sync passed and Tests passed. Attempt 1 (Templates in sync) was cancelled at its 15-minute limit because the pnpm cache was cold; the install takes about 10 minutes from scratch. Re-running only the failed job restored the cache saved by the Tests job, and every step includingCheck generated templatesthen passed. No workflow change or hook bypass was used.Review scope and risk
This maintainer-selected single PR contains 765 authored additions/deletions across six work units. It is intentionally not a PR chain. Review security boundaries and the Chatwoot migration first; the per-correction commits preserve rollback boundaries.
Risk: security/credential changes and tenant lifecycle/concurrency. Existing Twilio redirect handling is unchanged. Timestamp freshness limits stale replay, but deliveries within the five-minute window are not deduplicated.
Out of scope: other open PRs, other providers' webhook authentication, the previous audit reports/ODD tracker, real deployment configuration, and unrelated audit advisories. No existing PR is closed or merged by this change.
Contributor checklist
Refstype:breaking-change)Templates in syncandTestsare green on the reviewed head