Repository navigation
refactor(desktop): replace vuesax icons with Phosphor - #161
Merged
Merged
Conversation
Drop the vuesax SVG copies and their mask wrapper, import Phosphor icons directly, and type widget icons with Phosphor's Icon instead of Lucide's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web: ~970 copied SVGs, the generatedVuesaxNamelist, and the CSS-maskvuesax.tsxwrapper.@phosphor-icons/react(already a dependency). Renames went through the TypeScript language service, so only real references changed.strokeWidthprops were dropped (Phosphor draws filled outlines); the emphasised ones (2, 2.25) becameweight="bold".Iconinstead ofIconComponent/typeof X.apps/widgettypes widget/frame icons with Phosphor'sIconinstead ofLucideIcon, and dropslucide-react.components.jsonnow namesphosphoras shadcn's icon library.Icon mapping
Chevron → Caret, Search → MagnifyingGlass, Settings → GearSix, Threads → Chats, Workspace → Stack, Box → Cube, Server → HardDrives, MCP → PlugsConnected, Undo → ArrowCounterClockwise, Refresh → ArrowClockwise, GripVertical → DotsSixVertical, Pin/Unpin → PushPin/PushPinSlash, Maximize/Minimize → CornersOut/CornersIn, spinner → CircleNotch, plus the like-named ones (Check, X, Plus, Trash, Folder, Copy, ...).
Test plan
vp checkandvp run typecheckpass🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.