Skip to content

feat: project settings MCP and Skills; fix app server tests - #155

Merged
sanchitrk merged 3 commits into
canaryfrom
claude/desktop-app-pr-148-merge-3292ee
Nov 13, 2026
Merged

sanchitrk merged 3 commits into
canaryfrom
claude/desktop-app-pr-148-merge-3292ee

Conversation

@sanchitrk

@sanchitrk sanchitrk commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

What

MCP Connectors (project settings)

  • settings.read for mcp.json returns servers: the list the harness merges (McpConfig.load), each with its defining layer and whether it's on. The section draws its rows from that list, so a rejected override or skipped entry never shows the wrong state.
  • Turning on a user server that's off in the user mcp.json writes { enabled: true } in the project instead of dropping the override.
  • The section's error row reads "mcp.json has errors"; Advanced keeps the full message.

Skills (project settings, read-only)

  • One group per space: Local · main, Local · worktree, or <Sandbox> <provider id> with the folder below. A sandbox group says "synced 2h ago" or "not synced yet".
  • harness Skill.list(spaceId) runs the skill plugin's own discovery in the space's filesystem: the host each time, a sandbox only while it's online (it never wakes one).
  • codework skill.list RPC; app server projects.skills keeps the last read per space in a skill table, so a stopped sandbox shows its cached list.
  • A short placeholder grows into the real list; long lists fold to 5 skills and 3 spaces behind "Show N More".
  • A project with no host folder shows General, MCP Connectors and Advanced as "Not Available — Requires a host directory linked to this project".

App server

Testing

  • vp check, vp run typecheck.
  • CodeWork E2E: settings.read asserts servers; new skill.list case (host space with .codework, .agents and an ignored .claude folder, a running sandbox, a missing space).
  • apps/server: 26/26 non-live tests; live OrbStack recovery 5/5 and sync 12/12. Live artifacts regenerated for the machine rename and the current thread statuses.
  • Electron app with Kimi K3 (Copilot): MCP switches checked against runs; Skills groups match what a run in each space reports — main checkout, a worktree, and a real Daytona sandbox (live while online, cached once stopped, never woken).

🤖 Generated with Claude Code

sanchitrk and others added 3 commits November 11, 2026 22:17
settings.read now returns the merged mcp.json servers the harness
connects to, and the project settings page draws its rows from them, so
an override or entry the runtime rejects no longer shows the wrong state.
Turning on a user server that is off in the user file now writes
{ enabled: true } instead of dropping the override. The connectors
section says only that mcp.json has errors; Advanced keeps the detail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ests on Ubuntu

Since a run needs a model named in settings when no provider is configured,
the scripted CodeWork the app tests start never ran a prompt, so most suites
failed in their shared setup. The fixture now writes the test model into its
home, and the recovery suite names it in the settings it writes itself.

The live machine suites use Ubuntu only: the long-lived machine is `ubuntu`
in place of the retired `fedora`. Their artifacts are regenerated for that
name and for the current thread statuses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Project settings list the skills sessions in each of the project's spaces
see, read with the skill plugin's own discovery: a host checkout each time,
a sandbox only while it runs. The app keeps the last read per space, so a
stopped sandbox shows it with when it was synced and is never woken.

- harness: `Skill.list(spaceId)`; discovery takes a directory
- codework: `skill.list` RPC, with the sandbox's driver, id and status
- app server: `projects.skills`, cached in a `skill` table
- web: one group per space (main, worktree, sandbox), a placeholder that
  grows into the list, and long lists folded behind Show More
- settings for a project with no host folder say why General, MCP and
  Advanced are not available
- app migrations are one `init`, as nothing older exists to upgrade

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sanchitrk sanchitrk changed the title fix: show project MCP servers as sessions merge them feat: project settings MCP and Skills; fix app server tests Nov 11, 2026
@sanchitrk
sanchitrk merged commit c8ed8c5 into canary Nov 13, 2026
@sanchitrk
sanchitrk deleted the claude/desktop-app-pr-148-merge-3292ee branch November 13, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant