Skip to content

feat(desktop): build Windows installers and tighten the app on every OS - #133

Merged
sanchitrk merged 2 commits into
canaryfrom
claude/windows-build-desktop-app-127c9b
Nov 3, 2026
Merged

sanchitrk merged 2 commits into
canaryfrom
claude/windows-build-desktop-app-127c9b

Conversation

@sanchitrk

@sanchitrk sanchitrk commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Windows build: canary now packages an NSIS installer for Windows x64 and arm64 (windows-2025, windows-11-arm) beside the macOS and Linux builds. Adds resources/icon.ico (7 PNG sizes), runs pnpm through a shell on Windows in package.mjs, uses bash for the desktop job so "$CHANNEL" expands, and adds a SmartScreen note to the nightly release notes.
  • Config rename: electron-builder.config.ts → electron.config.ts.
  • Windows and WSL: the CodeWork server runs in WSL, so on Windows the bridge offers no native folder dialog or Reveal. Add Project picks folders from the server (Local Folder, which also reaches /mnt/c/…).
  • App server: stops itself when Electron is gone on Windows too, since Windows never reparents an orphan.
  • Every OS:
    • Single-instance lock: a second launch focuses the open window instead of starting a second app server.
    • Windows AppUserModelID, so the taskbar button joins the Start-menu shortcut's.
    • Menu bar hidden until Alt on Windows and Linux.
    • Dock icon set only when unpackaged.
    • Hidden window unthrottled until it shows.
    • Links that open a new window (a reply's links) open in the browser.
    • Installers ship only the en-US locale.
    • macOS 26 one-time-code autofill turned off.
    • Fuller .deb dependencies (ALSA, GBM, the t64 package names).

Not yet

  • No manual connect by URL yet, so the Windows app can't reach a server in WSL until that lands.
  • Windows builds are unsigned.

Testing

  • vp check and vp run typecheck pass.
  • No installer was built locally: Windows packaging needs a Windows runner, and the desktop job runs only on pushes to canary, so the first real Windows build is the canary run after merge. The new main-process behaviour hasn't been exercised in a running app.

🤖 Generated with Claude Code

sanchitrk and others added 2 commits November 3, 2026 19:10
The app server stopped itself once its parent's pid changed, but Windows
never reparents an orphan, so a crashed or killed app left it running.
It now also asks whether the parent still runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Canary now packages an NSIS installer for Windows x64 and arm64 beside the
macOS and Linux builds, with a Windows icon, and package.mjs runs pnpm
through a shell on Windows. The builder config is now electron.config.ts.

On Windows the CodeWork server runs in WSL, so the bridge offers no native
folder dialog or reveal: Add Project picks folders from the server.

The app also takes the running app's id as its AppUserModelID, so its
taskbar button joins the shortcut's; focuses the open window on a second
launch rather than starting a second app server; hides the menu bar until
Alt; sets the Dock icon only when unpackaged; keeps the hidden window
unthrottled until it shows; and opens new-window links in the browser.
Installers ship only the en-US locale, macOS opts out of one-time code
autofill, and the deb names the libraries Electron loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sanchitrk
sanchitrk merged commit ce89685 into canary Nov 3, 2026
1 check passed
@sanchitrk
sanchitrk deleted the claude/windows-build-desktop-app-127c9b branch November 3, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant