Repository navigation
feat(desktop): build Windows installers and tighten the app on every OS - #133
Merged
Merged
Conversation
The app server stopped itself once its parent's pid changed, but Windows never reparents an orphan, so a crashed or killed app left it running. It now also asks whether the parent still runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Canary now packages an NSIS installer for Windows x64 and arm64 beside the macOS and Linux builds, with a Windows icon, and package.mjs runs pnpm through a shell on Windows. The builder config is now electron.config.ts. On Windows the CodeWork server runs in WSL, so the bridge offers no native folder dialog or reveal: Add Project picks folders from the server. The app also takes the running app's id as its AppUserModelID, so its taskbar button joins the shortcut's; focuses the open window on a second launch rather than starting a second app server; hides the menu bar until Alt; sets the Dock icon only when unpackaged; keeps the hidden window unthrottled until it shows; and opens new-window links in the browser. Installers ship only the en-US locale, macOS opts out of one-time code autofill, and the deb names the libraries Electron loads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-2025,windows-11-arm) beside the macOS and Linux builds. Addsresources/icon.ico(7 PNG sizes), runspnpmthrough a shell on Windows inpackage.mjs, uses bash for the desktop job so"$CHANNEL"expands, and adds a SmartScreen note to thenightlyrelease notes.electron-builder.config.ts→electron.config.ts./mnt/c/…)..debdependencies (ALSA, GBM, the t64 package names).Not yet
Testing
vp checkandvp run typecheckpass.canary, so the first real Windows build is the canary run after merge. The new main-process behaviour hasn't been exercised in a running app.🤖 Generated with Claude Code