Repository navigation
fix(harness): end MCP lists at a blank cursor and hide TypeError messages - #128
Merged
Merged
Conversation
…ages A server's `nextCursor: ""` is now dropped from every list result, so the SDK's page walk and the resource tools treat it as the last page instead of restarting until the page cap. A TypeError without a system code is described as `invalid request (TypeError)`: the runtime's own errors, such as an invalid header name, may quote the rejected value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nextCursor: ""is dropped from every MCP list result at the transport, before the SDK sees it. The SDK's page walk (tools, resources, templates, prompts) and the resource tools now end there instead of restarting until the 64-page cap. The empty-cursor expectation inmcp.client.test.tsflips accordingly.describe()returnsinvalid request (TypeError)for a TypeError without a system code, so the runtime's own errors (an invalid header name, say) no longer reach the server status, warnings or tool results with what they rejected. TypeErrors with a code keepfetch failed (ECONNREFUSED).Tests
test/mcp.followups.test.ts: a stdio fixture whose second pages end in"", plus an HTTP server with a header fetch rejects. Snapshots paging, status, events, log and warnings to__artifacts__/mcp-review-followups.jsonand asserts the header name and value appear nowhere.test/mcp.*.test.tspass (60 tests);vp checkandvp run typecheckpass.🤖 Generated with Claude Code