Add comprehensive image processing tests and improve error handling - #25
Merged
Merged
Conversation
…e temporary file Tests cover resizing, maxsize clamping, EXIF orientation, conversion (HEIC and GIF), overwrite confirmation for converted names and delegate safety. A corrupt image now gives an error message instead of a fatal ImagickException and no longer leaves the -tmp-process file behind. CI installs the imagick extension. Closes #16 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011k94dX3j9otoThuhZM9YSd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive integration tests for image processing functionality (resizing, EXIF orientation, and format conversion) and improves error handling to prevent leaving corrupted files behind when processing fails.
Key Changes
Tests (
tests/Integration/ImageProcessingTest.php)Core Functionality (
index.php)ImagickExceptionTest Infrastructure
tests/README.mdto document imagick dependency and HEIC test requirementsImplementation Details
https://claude.ai/code/session_011k94dX3j9otoThuhZM9YSd