Skip to content

Take the Transform modules from notebook-language-server-core - #8

Merged
thomasjm merged 1 commit into
process-os-stringfrom
move-transform-to-core
Oct 12, 2026
Merged

thomasjm merged 1 commit into
process-os-stringfrom
move-transform-to-core

Conversation

@thomasjm

Copy link
Copy Markdown
Contributor

783 lines deleted here. Ten modules move to core, now that DocumentState is parameterized and none of them name RustNotebookTransformer:

Language.LSP.NotebookLanguageServer.Transform.Util
                                             .Common
                                             .ClientReq
                                             .ClientRsp
                                             .ClientNot.DidSave
                                             .ServerNot
                                             .ServerReq
                                             .ServerRsp
                                             .ServerRsp.Hover
                                             .ServerRsp.Formatting

This repo keeps four modules: its two transformers, their index, and Transform/ClientNot.hs, which is where didOpen builds the transformer and appends .rs. A parameterized version of that is the next change.

ServerRsp.Formatting going to core is worth noting — it is the unproject-based untransform that lets a formatter's output map back into a cell. cpp, go and haskell get it as soon as they implement unproject, which is what currently blocks notebook formatting for them.

-Wunused-packages caught five dependencies that went with the code: lens-regex-pcre, network-uri, pcre-light, random, safe.

19 tests pass.

@thomasjm
thomasjm force-pushed the move-transform-to-core branch from 9fb202c to aab644f Compare October 12, 2026 03:18
@thomasjm
thomasjm changed the base branch from master to process-os-string October 12, 2026 03:18
@thomasjm
thomasjm merged commit b7c96ff into process-os-string Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant