Repository navigation
Fix build with string-interpolate 1.0.0.0 - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string-interpolate 1.0.0.0 switched its interpolation parser to
ghc-hs-meta, whosetoTypeonly handles bare type variables and constructors. Applied types likeProxy ahit anerrorcall at compile time, so the two(Proxy :: Proxy a)annotations inside[i|...|]broke every cabal CI job.Use visible type application instead, which
ghc-hs-metadoes handle, and which matches the style already used for theMap/HashMapinstances. Verified the library and test suite build and all 49 tests pass against both string-interpolate 1.0.0.0 and the 0.3.x pinned by the stack snapshots.