fix: refactor upload_process command into _logic function - #775
Open
sentry[bot] wants to merge 1 commit into
Open
fix: refactor upload_process command into _logic function#775sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
upload_processcommand incodecov_cli/commands/upload_process.pywas not following the established pattern of delegating its core logic to a_logicfunction in theservicesdirectory. This led to anAttributeErrorwhen a test script (token2.py) attempted tomock.patcha non-existentupload_process_logicattribute.This PR refactors the
upload_processcommand:codecov_cli/services/upload_process/__init__.py.upload_processcommand into a new functionupload_process_logicwithin this service module.upload_processcommand to import and callupload_process_logic, passing the necessary arguments.This change aligns
upload_processwith the architectural pattern used by other commands (e.g.,upload_coverage) and resolves theAttributeErrorby makingupload_process_logicavailable for patching.Fixes CLI-GQ
This PR was automatically generated by Sentry. You can adjust this setting at any time.