Skip to content

fix: refactor upload_process command into _logic function - #775

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/upload-process-logic-refactor
Open

fix: refactor upload_process command into _logic function#775
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/upload-process-logic-refactor

Conversation

@sentry

@sentry sentry Bot commented Aug 25, 2026

Copy link
Copy Markdown

The upload_process command in codecov_cli/commands/upload_process.py was not following the established pattern of delegating its core logic to a _logic function in the services directory. This led to an AttributeError when a test script (token2.py) attempted to mock.patch a non-existent upload_process_logic attribute.

This PR refactors the upload_process command:

  1. Creates a new service module codecov_cli/services/upload_process/__init__.py.
  2. Moves the core logic of the upload_process command into a new function upload_process_logic within this service module.
  3. Updates the upload_process command to import and call upload_process_logic, passing the necessary arguments.

This change aligns upload_process with the architectural pattern used by other commands (e.g., upload_coverage) and resolves the AttributeError by making upload_process_logic available for patching.

Fixes CLI-GQ

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
723 1 722 1
View the full list of 1 ❄️ flaky test(s)
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 100.00% (Passed 0 times, Failed 1726 times)

Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants