Repository navigation
os-image: redroid takes scrcpy-rfb from the immutable master-827baf531 release - #289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redroid 16 image now takes scrcpy-rfb from the immutable
master-827baf531release instead of the movingmasterrelease.Why
build-os-images run 39908133499 (on 991ec16) failed only in
ubuntu/22.04-redroid-16.0-gms-h264. The Dockerfile's own pin check stopped it:The
masterrelease is overwritten on every scrcpy-rfb master build, so the pin breaks as soon as master moves. scrcpy-rfb#11 added immutablemaster-<sha>releases. Pinning the tag and the commit together makes the build reproducible again.What the bump brings in, from 9bdf6ed2 to 827baf53:
remoteview.Dockerfilecarries the same pins and gets the same bump; the README says both must move together. The README sentence now describes the tag pin.Checks
master-827baf531build-info.json:"commit": "827baf531715d6b86482c7ac6c63fd31030c58aa".scrcpy-rfb-linux-{amd64,arm64},scrcpy-server-secure.jar,su1000-linux-{amd64,arm64}) is in the release. Each passessha256sum -cagainst its.sha256file and matches its line inSHA256SUMS.docker build --platform linux/arm64 -f remoteview.Dockerfileruns the same fetch block, passes the pin check and all threesha256sum -cchecks, and installs the expected digests.