Repository navigation
fix: an unparsable WEBHOOK_LOG_LEVEL prints its error before the exit; comment budget - #25
Merged
Merged
Conversation
SetupLog fails before the global logger exists, so Fatalf went through a disabled logger and the pod crash-looped with empty logs. The error now goes to stderr, as in the operator and vk-cocoon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WEBHOOK_LOG_LEVELnow prints its error before exiting.SetupLogfails before the global logger exists, soFatalfwent through a disabled logger and the pod crash-looped with empty logs. The error now goes to stderr, as in the operator and vk-cocoon.Evidence
Linux container,
WEBHOOK_LOG_LEVEL=verbose:rc=1, no output.rc=1,setup log: Unknown Level String: 'verbose', defaulting to NoLevel.Gates:
make fmt-checkandmake lint: 0 issues.go test -race ./...: pass.aslon darwin and linux: clean.Size: prod +9/-10.