Repository navigation
Conversation
laozidabo
marked this pull request as ready for review
October 26, 2026 03:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321.
On Windows, Typer expands
sys.argvagainst local files before parsing it. Withdocs/a.mdanddocs/b.mdpresent,ccc search "some query" --path "docs/*"loses its glob filter and appends a filename to the query.Route the installed
ccccommand andpython -m cocoindex_code.clithrough onemain()that callsapp(windows_expand_args=False). This preserves literal search patterns. The legacycocoindex-codeMCP entry point is unchanged. The flag disables Windows automatic argument expansion as a whole, including glob, tilde, and environment-variable expansion.Add four regression cases covering both public CLI entry points with ordinary and glob-shaped query strings. They use real argv parsing and matching local files, simulate Typer's Windows branch without changing the process-wide OS, and intercept the search request before starting a daemon or model.
Validation:
tests/test_cli_entrypoint.pyandtests/test_cli_helpers.pypass (39 tests) on Linux/Python 3.11 with the locked runtime dependencies.git diff --checkpass.uv run prek run --all-filespasses on Linux/Python 3.11: formatting, lint, secret scanning, dependency-lock validation, mypy, and the configured pytest suite. Docker E2E tests are excluded by the project's default configuration.AI assistance: OpenAI Codex investigated, implemented, and tested this change on behalf of @laozidabo. The account owner has not personally written or technically reviewed the code.