Repository navigation
Conversation
- Accept `prompt` in LiteLLM `indexing_params` and `query_params` - Prepend it to each text before the request instead of sending it as an API parameter - Support OpenAI-compatible servers such as llama.cpp that apply no model prompts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LiteLLM
indexing_paramsandquery_paramsnow acceptprompt, a literal prefix prepended to each text before the embedding request. This lets models that expect task prefixes, such as EmbeddingGemma (title: none | text:for documents,task: code retrieval | query:for queries), run behind OpenAI-compatible servers like llama.cpp, which apply no model prompts of their own.Design
promptis applied inPacedLiteLLMEmbedder.run_embedding_requestand never forwarded tolitellm.aembedding.create_embedderpassesindexing_paramsto the constructor as default kwargs, so handling it at the request boundary covers both paths: a per-callprompt(query side) overrides the constructor default (indexing side), and neither reaches the server as an unknown API parameter.promptjoinsinput_typein the accepted LiteLLM keys, theccc inittemplate comment, and the README.Validation
uv run pytest tests/test_litellm_embedder.py tests/test_embedder_params.py tests/test_embed_params_forwarding.py tests/test_settings.py: 98 passed.uv run ruff check src testsanduv run mypy srcpass.ccc doctorpasses both model checks.