Add JSON APIs for submission details and use them in SolutionChecker.py - #1712
Add JSON APIs for submission details and use them in SolutionChecker.py#1712veluca93 wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
==========================================
+ Coverage 55.05% 56.68% +1.63%
==========================================
Files 339 344 +5
Lines 27401 28238 +837
==========================================
+ Hits 15085 16007 +922
+ Misses 12316 12231 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| is_analysis_mode = self.r_params["actual_phase"] == 3 | ||
| if submission.tokened() or is_analysis_mode: | ||
| raw_details = sr.score_details | ||
| else: | ||
| raw_details = sr.public_score_details | ||
|
|
||
| if is_analysis_mode: | ||
| feedback_level = FEEDBACK_LEVEL_FULL | ||
| else: | ||
| feedback_level = task.feedback_level |
There was a problem hiding this comment.
this logic is duplicated with tasksubmission.py, maybe it should be factored out somewhere (to ensure they stay in sync mainly)
There was a problem hiding this comment.
I added a commit on top that refactors that logic, PTAL - I am not fully convinced, but if you like it I'll fold it into the relevant commit :-)
Includes an admin-only full_details endpoint.
- Subtask assertions - Admin token support - Final report table
bc08ea8 to
e82cec0
Compare
2 participants
No description provided.