Fix cloudstack_nic ignoring project scope - #5
Closed
ysamarah wants to merge 1 commit into
Closed
Conversation
resourceCloudStackNICRead looks the parent instance up with GetVirtualMachineByID without passing a project. listVirtualMachines does not return guests that belong to a project unless projectid is supplied, so the lookup finds nothing, the NIC is treated as deleted, and Terraform removes it from state. Because Read runs immediately after Create, attaching a NIC to a guest in a project always fails the apply with "Provider produced inconsistent result after apply ... Root object was present, but now absent", even though the NIC was created correctly in CloudStack. Add an optional project argument and scope the read with cloudstack.WithProject, the same way resource_cloudstack_instance and resource_cloudstack_affinity_group already do. WithProject is a no-op for an empty value, so behaviour is unchanged when no project is set. Also add an importer. The parent instance cannot be derived from a NIC ID alone, so it takes <virtual_machine_id>/<nic_id>, or <project>/<virtual_machine_id>/<nic_id> for a guest in a project. This is the same class of bug as apache#319 (instance data source ignoring project scope) and apache#293 (userdata not found when added to a project). Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Closing; opened in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.