Skip to content

fix: log transient connectivity errors during WAL restore #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gbartolini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: log transient connectivity errors during WAL restore #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/cnpgi/common/wal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,11 @@ func (w WALServiceImplementation) restoreFromBarmanObjectStore(
// is the one that PostgreSQL has requested to restore.
// The failure has already been logged in walRestorer.RestoreList method
if walStatus[0].Err != nil {
if errors.Is(walStatus[0].Err, barmanRestorer.ErrConnectivity) {
// Only available from Barman 3.20.0
contextLogger.Info("transient connectivity issue while restoring WAL, will retry",
"walName", walStatus[0].WalName, "error", walStatus[0].Err)
}
return classifyWALRestoreError(walStatus[0].WalName, walStatus[0].Err)
}

Expand Down
Loading