Conversation
fcanovai
force-pushed
the
dev/168-v2
branch
from
September 22, 2026 10:12
83d81f8 to
e3abbaa
Compare
Implement our own retention policy system. Kopia retention policies could not consider Klio backups atomically, as Kopia applies its retention policies to the snapshots. A backup is composed by a set of snapshots, and a backup updated partially due to a failure could remove some of the snapshot and leave others, resulting in missing snapshots and misaligned data. This PR drops the Kopia retention policies in favour of Klio managed ones. Currently only 'latest' is supported. The retention policies are still defined by the PluginConfiguration, but are sent to the Klio server on backup, and the Klio server has a worker that routinely cleans backups that are out of policy. This implementation relies on the backup metadata being written last during a backup. A backup is the set of snapshots that is identified by the metadata. Snapshots without related metadata that older than an existing backup are considered orphans and deleted. BREAKING CHANGE: old retention policies are no longer supported. Users should apply update their PluginConfiguration resources to use the new format. Closes #168 Assisted-by: Claude Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
fcanovai
force-pushed
the
dev/168-v2
branch
from
September 22, 2026 10:12
e3abbaa to
616e62f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement our own retention policy system.
Kopia retention policies could not consider Klio backups atomically, as Kopia applies its retention policies to the snapshots. A backup is composed by a set of snapshots, and a backup updated partially due to a failure could remove some of the snapshot and leave others, resulting in missing snapshots and misaligned data.
This PR drops the Kopia retention policies in favour of Klio managed ones. Currently only 'latest' is supported. The retention policies are still defined by the PluginConfiguration, but are sent to the Klio server on backup, and the Klio server has a worker that routinely cleans backups that are out of policy.
This implementation relies on the backup metadata being written last during a backup. A backup is the set of snapshots that is identified by the metadata. Snapshots without related metadata that older than an existing backup are considered orphans and deleted.
BREAKING CHANGE: old retention policies are no longer supported. Users should apply update their PluginConfiguration resources to use the new format.
Closes #168