fix(types): allow undefined or optional argument in DurableObjectNamespace.jurisdiction - #7547
Open
spideydotjs wants to merge 2 commits into
Open
spideydotjs wants to merge 2 commits into
spideydotjs wants to merge 2 commits into
Conversation
…space.jurisdiction Fixes cloudflare#6551. At runtime, DurableObjectNamespace.prototype.jurisdiction accepts an optional argument (undefined or omitted), which defaults or clears the jurisdiction constraint. This is commonly used in patterns such as: const jurisdiction = env.WORKER_ENV ? 'eu' : undefined; env.MY_DO.jurisdiction(jurisdiction); However, the TypeScript definition declared jurisdiction as required, rejecting undefined or empty calls at typecheck time. Mark the jurisdiction parameter as optional in the JSG_TS_OVERRIDE blocks in actor.h, update the generated type snapshots, and add type tests.
cjol
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6551.
At runtime,
DurableObjectNamespace.prototype.jurisdiction(maybeJurisdiction)accepts an optional argument (undefinedor omitted), clearing or defaulting the jurisdiction constraint (implemented in #4763). This is commonly used in patterns such as:However, the TypeScript definition declared
jurisdictionas a required parameter (jurisdiction: DurableObjectJurisdiction), which caused TypeScript to rejectundefinedor zero-argument invocations.This change marks the parameter as optional (
jurisdiction?: DurableObjectJurisdiction) insrc/workerd/api/actor.h, updates the generated type snapshots, and adds type-level tests intypes/test/types/do.ts.