Repository navigation
feat(date-picker): refresh styling with Kumo tokens - #900
Open
khoinguyenpham04 wants to merge 2 commits into
Open
khoinguyenpham04 wants to merge 2 commits into
khoinguyenpham04 wants to merge 2 commits into
Conversation
The `.kumo-prose` table rules also applied inside `.not-prose` demos, so the DatePicker weekday row rendered bold in its inline examples. Skip `.not-prose` like the neighboring prose rules do, and give PropsTable its header color directly so it looks the same.
Style DatePicker with Kumo token classes on each react-day-picker part instead of the hard-coded `.rdp-*` block in kumo.css, so it follows the active theme and kumo-standalone.css styles it too. The month-change animations move to kumo-binding.css so both stylesheets ship them, and they respect prefers-reduced-motion. - Days are 32px squares in 36px columns with 8px between weeks and 14px text. The previous and next buttons are borderless squares that stay grouped at the end of the header. - Two-month views sit side by side, and range bands are rounded at their ends and where weeks wrap. - Style month and year dropdowns, and flip the arrows in RTL. - Keep the component free of internal padding. The inline docs examples set it with `className="p-3"`, and Popover examples keep `p-3`. - Docs: add a month and year dropdown example, and fix the presets example's active highlight.
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
commit: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refreshes DatePicker's styling with Kumo tokens. It keeps the component's layout model from early feedback: no internal padding, so the container sets the spacing, and the previous and next buttons grouped together at the end of the header.
Before and after
Month and year dropdowns (
captionLayout="dropdown"), now styled:Changes
date-picker.tsxas Kumo token classes on each react-day-picker part, so it follows the active theme, FedRAMP included. The.rdp-*block inkumo.cssis removed.kumo-binding.css, sokumo-standalone.cssnow includes DatePicker styles and animations too. They respectprefers-reduced-motion..rdp-*rules or--rdp-*variables would move to theclassNamesprop.Docs
className="p-3", the same way an app would.Testing
tsc,vp lintandvp fmt --checkare clean.