Repository navigation
Feat/sidebar hover preview - #899
Open
sophiacalfred-uxdesign wants to merge 3 commits into
Open
sophiacalfred-uxdesign wants to merge 3 commits into
sophiacalfred-uxdesign wants to merge 3 commits into
Conversation
Gate previews behind `previewOnHover` on Sidebar.Provider, and preview collapsed-rail sections regardless of open state. Title the top-level popup from the trigger and suppress its tooltip so the two never overlap. Fall back to a menu button's own text for its collapsed-rail tooltip. Add a docs demo and section.
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
feat(sidebar): add hover previews for nested collapsible content
Description
Fixes #[insert GH or internal issue link(s)].
Adds opt-in hover previews to
Sidebar, so nested navigation is reachable without expanding sections inline — especially useful on the collapsed icon rail, which can't render nested content at all.What's new
previewOnHoveronSidebar.Provider(defaultfalse). Hovering a closedSidebar.Collapsibleshows itsCollapsibleContentin a floating popup instead of expanding inline. On the collapsed rail, sections preview regardless of open state.tooltip, or its text when omitted) and replaces the trigger's own tooltip. Styled likeSidebar.GroupLabel. Nested popups omit it.Sidebar.MenuButtonfalls back to its own text for the collapsed-rail tooltip when notooltipis set, so every icon-only item gets a label.Accessibility
Previews are a mouse-only affordance: the popup is
aria-hiddenand its contents are removed from the tab order. Keyboard and assistive-tech users keep the existing behaviour (inline expansion on focus).Docs
New "Hover Preview" section and demo on the Sidebar page.