Skip to content

feat(layer-dialog): add body separator - #895

Merged
mattrothenberg merged 1 commit into
cloudflare:mainfrom
invisal:feat/layer-dialog-separator
Oct 27, 2026
Merged

mattrothenberg merged 1 commit into
cloudflare:mainfrom
invisal:feat/layer-dialog-separator

Conversation

@invisal

@invisal invisal commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add full width divider component
LayerDialog.Separator

  <LayerDialog.Body>
    <Text variant="secondary">
      production-api will deploy to the global network.
    </Text>
    <LayerDialog.Separator />
    <Text variant="secondary">
      The deployment uses compatibility date 2026-10-26.
    </Text>
  </LayerDialog.Body>
image

Testing

  • pnpm exec vp test run --project=unit src/components/layer-dialog/layer-dialog.test.tsx
  • pnpm --filter @cloudflare/kumo typecheck
  • pnpm --filter @cloudflare/kumo-docs-astro typecheck
  • pnpm --filter @cloudflare/kumo lint
  • pnpm --filter @cloudflare/kumo-docs-astro lint

Reviews

  • bonk has reviewed the change
  • automated review not possible because: automated review was not requested in this local workflow

Tests

  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows: not applicable
  • Additional testing not necessary because: not applicable

@clanky-the-clanker

Copy link
Copy Markdown

This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting clanky review (or clanker review or @clanky-the-clanker review), optionally followed by instructions (e.g. clanky review focus on the retry logic).

@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@895

commit: 7ac9588

@mattrothenberg

Copy link
Copy Markdown
Collaborator

clanky review

@github-actions

Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 7ac9588

@github-actions

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 166.6 KB 50.9 KB 44.3 KB
Button (components/button) 166.5 KB 50.9 KB 44.2 KB
Button + Dialog + Select (root) 293.4 KB 87.5 KB 73.6 KB
Button + Dialog + Select (component subpaths) 293.5 KB 87.6 KB 73.6 KB
Chart (root) 238.5 KB 71.9 KB 61.9 KB
Chart (components/chart) 238.5 KB 71.9 KB 61.9 KB
Badge (components/badge) 36.5 KB 12.7 KB 11.1 KB
Flow (components/flow) 200.7 KB 59.2 KB 51.8 KB
Button (primitives/button) 12.4 KB 4.5 KB 4.0 KB
Primitives barrel 718.4 KB 198.5 KB 154.5 KB
Code highlighting (code) 2.07 MB 469.2 KB 350.6 KB

npm tarball: 564 files, 1.56 MB packed, 7.30 MB unpacked.

⚠️ 24 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/delete-resource/delete-resource.test.tsx
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-globe-land-mask.mjs
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: 7ac9588f

@github-actions

Copy link
Copy Markdown
Contributor

Visual contracts

Linux Chromium references exercised by the PR's visual-contracts job.

1 curated contract

truncating text trigger

truncating text trigger

@mattrothenberg
mattrothenberg merged commit 890a6ab into cloudflare:main Oct 27, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants