Repository navigation
fix: use latest Forge OpenAPI release - #334
Merged
Merged
Conversation
petebacondarwin
requested review from
a team,
dimitropoulos and
srikrsna
as code owners
October 16, 2026 16:14
Contributor
|
LGTM |
commit: |
Contributor
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 217.2 ms | 8.6 ms | 210.9 ms | 248.9 ms |
| base | 214.7 ms | 3.8 ms | 208.9 ms | 221.8 ms |
Δ (PR vs base): ↑ +2.6 ms (+1.2%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
petebacondarwin
changed the title
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
|
🤖 I've done a thorough review of your PR. Updates OpenAPI release discovery to use GitHub’s
|
srikrsna
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAPI updater returns the first eligible release from GitHub's list, which can select an older spec when releases share a target commit. Fetch
/repos/cloudflare/forge/releases/latestinstead, using GitHub's latest-release marker with one lookup regardless of release-history size.Validate that the response is a published, non-prerelease
openapi@<sha>release with the requiredopenapi.forge.jsonasset. Report missing or invalid latest releases without falling back to scanning history. Forge's publisher must keep its latest marker on the current OpenAPI spec.Validation:
node --test scripts/update-openapi.test.ts— all 21 tests pass, covering the direct anonymous lookup, invalid releases, missing assets, 404 responses, and retries.pnpm check— passes generation, builds, workspace type checks, lint, and formatting.git diff --check— passes.No changeset: this only changes internal update automation.